Hi! > > > >>Right. > > > >> > > > >>Before reverting, can you please try if this patch works or not? > > > > > > > >Not really. Revert now. Sorry. > > > > > > > >Are you sure? This does not look equivalent to me at all. > > > > > > > >"name" file handling moved from drivers to the core, which added some > > > >crazy checks what name can contain. Even if this "works", what is the > > > >expected effect on the "name" file? > > > > > > > The hwmon name attribute must not include '-', as documented in > > > Documentation/hwmon/sysfs-interface. Is enforcing that 'crazy' ? > > > Maybe in your world, but not in mine. > > > > Well, lets revert the patch and then we can discuss what to do with > > the "name" problem. Ok, so the patch is on the way in. What to do next? pavel@n900:/sys/class/hwmon$ cat hwmon0/name bq27200-0 pavel@n900:/sys/class/hwmon$ cat hwmon1/name rx51-battery > To provide some detail: libsensors gets just as confused with wildcards > and whitespace/newline as it does with '-' in the reported name, which > is why those are blocked by the new API. Ok... Question is "does someone actually use hwmon*/name on N900"? If so, we can't change it, but it is well possible that noone is. Next question is .. are there other drivers affected? Do we want to do '-' -> '_' in the core or somewhere in the drivers? We might want to do the change in early in 4.11 and see what breaks.... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
