* Adam Ford <aford173@xxxxxxxxx> [170123 11:51]:
> On Mon, Jan 23, 2017 at 12:58 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> > * aford173@xxxxxxxxx <aford173@xxxxxxxxx> [170120 10:10]:
> >> From: Adam Ford <aford173@xxxxxxxxx>
> >>
> >> This fixes commit ab8dd3aed011 ("ARM: DTS: Add minimal Support for
> >> Logic PD DM3730 SOM-LV") where the system may not successfully
> >> start after a reboot.
> >
> > Hmm so what goes wrong here? And which compatible do you end up
> > using that works?
>
> The issue was the bootloader (MLO) would load, but it would throw an
> error unable to load anything (like U-boot) from the MMC. After
> reading the binding, the twl4030-power-reset seemed like a good
> option, so I added it.
OK..
> I didn't think the compatible options were mutually exclusive, because
> the original device tree you did the for the Torpedo had both
> "ti,twl4030-power-idle-osc-off", "ti,twl4030-power-idle" enabled, so I
> added the "ti,twl4030-power-reset" option.
>
> Looking at binding, I thought I should have the more generic
> compatible = "ti,twl4030-power" added, but it doesn't appear to change
> the behavior, so I'm ok with removing that.
>
> Either way, it appears as if II need the "ti,twl4030-power-reset" to
> address the bootloader hanging. Does that mean I have to remove the
> other "ti,twl4030-power-idle-osc-off", "ti,twl4030-power-idle" flags?
Hmm I think we may have a bug somewhere. The "ti,twl4030-power-reset"
should be a subset of "ti,twl4030-power-idle" which is a subset of
"ti,twl4030-power-idle-osc-off".
Maybe try adding some printks to the driver to see if the power-reset
features are configured with power-idle-osc-off?
>From PM point of view, you really want to use all features with
"ti,twl4030-power-idle-osc-off" if your hardware allows cutting off
the oscillator during idle :)
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
