On Thu, May 07, 2009 at 10:11:07PM +0200, ext Felipe Contreras wrote: > -static struct resource omap3_iommu_res[] = { > - { /* Camera ISP MMU */ > - .start = OMAP3_MMU1_BASE, > - .end = OMAP3_MMU1_BASE + MMU_REG_SIZE - 1, > - .flags = IORESOURCE_MEM, > - }, > - { > - .start = OMAP3_MMU1_IRQ, > - .flags = IORESOURCE_IRQ, > - }, > - { /* IVA2.2 MMU */ > - .start = OMAP3_MMU2_BASE, > - .end = OMAP3_MMU2_BASE + MMU_REG_SIZE - 1, > - .flags = IORESOURCE_MEM, > - }, > - { > - .start = OMAP3_MMU2_IRQ, > - .flags = IORESOURCE_IRQ, > - }, i find this one much more readable :-s > +struct iommu_device { > + resource_size_t base; > + resource_size_t irq; > + struct iommu_platform_data pdata; generally, platform_data is a void *. Don't know if it matters here. > + struct resource res[2]; > }; > -#define NR_IOMMU_RES (ARRAY_SIZE(omap3_iommu_res) / 2) > > -static const struct iommu_platform_data omap3_iommu_pdata[] __initconst = { > +static struct iommu_device devices[] = { > { > - .name = "isp", > - .nr_tlb_entries = 8, > - .clk_name = "cam_ick", > + .base = 0x480bd400, > + .irq = 24, > + .pdata = { > + .name = "isp", > + .nr_tlb_entries = 8, > + .clk_name = "cam_ick", still passing clk names ? what about clkdev ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html