RE: [PATCH 2/6] omap iommu: omap2 architecture specific functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

> +static irqreturn_t iommu_fault_handler(int irq, void *data)
> +{
> +       u32 stat, da;
> +       u32 *iopgd, *iopte;
> +       int err = -EIO;
> +       struct iommu *obj = data;
> +
> +       if (!obj->refcount)
> +               return IRQ_NONE;
> +
> +       /* Dynamic loading TLB or PTE */
> +       if (obj->isr)
> +               err = obj->isr(obj);
> 		      ^^^^^^^^^^^^^^
> 
> If the above "isr" function sets a new "tlb" or "pte" entry, then
> further iommu fault won't happen anymore.
>

-- I think adding the new tlb entry or any other error recovery mechanism should be deferred to the registered callback function. 

Thank you,
Best regards,
Hari
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux