From: Liam Breck <kernel@xxxxxxxxxxxxxxxxx>
The interrupt signal is TRIGGER_FALLING. This is is specified
in the data sheet "PIN FUNCTIONS":
"The INT pin sends active low, 256 us pulse to hos to report charger
device status and fault."
Also the direction can be seen in the data sheet "Figure 1. bq24190
with D+/D- Detection and USB On-The-Go (OTG)" that shows a 10k pull-up
resistor installed for the sample configurations.
Fixes: d7bf353fd0aa3 ("bq24190_charger: Add support for TI BQ24190
Battery Charger")
Cc: Mark A. Greer <mgreer@xxxxxxxxxxxxxxx>
Cc: Matt Ranostay <matt@ranostay.consulting>
Signed-off-by: Liam Breck <kernel@xxxxxxxxxxxxxxxxx>
[tony@xxxxxxxxxxx: updated patch description]
Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
---
drivers/power/supply/bq24190_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -1395,7 +1395,7 @@ static int bq24190_probe(struct i2c_client *client,
irq_set_status_flags(bdi->irq, IRQ_NOAUTOEN);
ret = devm_request_threaded_irq(dev, bdi->irq, NULL,
bq24190_irq_handler_thread,
- IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+ IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
"bq24190-charger", bdi);
if (ret < 0) {
dev_err(dev, "Can't set up irq handler\n");
--
2.11.0
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
