* Bin Liu <b-liu@xxxxxx> [170111 05:42]: > On Tue, Jan 10, 2017 at 01:53:53PM -0600, Bin Liu wrote: > > On Thu, Jan 05, 2017 at 11:12:59AM -0800, Tony Lindgren wrote: > > > We can now configure the PMIC interrupt to provide us VBUS > > > events. In that case we don't need to constantly poll the > > > status and can make it optional. This is only wired up > > > for the mini-B interface on beaglebone. > > > > Is it possible someone designed a board which hooks up the vbus of a > > dual-role/otg port to PMIC? The port wouldn't be able to detect the > > attach since no polling anymore. > > I haven't seen any am335xx design other than the Beaglebone, that routes > VBUS to PMIC, and I guess the reason that Beaglebone did this way is > only for supporting bus-powered. Yeah I guess that remains to be seen. I guess it could also be configured to use any 5V GPIO in the dts and ideally and work the same way. > > > +static int dsps_setup_optional_vbus_irq(struct platform_device *pdev, > > > + struct dsps_glue *glue) > > > +{ > > > + int error; > > > + > > How about check dr_mode at here, and simply return if dr_mode is not > "peripheral". So this ensures this VBUS irq is only used for device > mode, it clear my concern above. Yeah OK I like your idea of limiting it to peripheral only for now. Will repost with your other comments addressed also. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html