Quoting Tero Kristo (2016-12-02 00:15:53) > On 29/10/16 02:37, Stephen Boyd wrote: > > On 10/28, Tero Kristo wrote: > >> Eventually that should happen. However, we have plenty of legacy > >> code still in place which depend on clk_get functionality within > >> kernel. The major contributing factor is the hwmod codebase, for > >> which we have plans to: > >> > >> - get this clock driver merged > >> - implement a new interconnect driver for OMAP family SoCs > >> - interconnect driver will use DT handles for fetching clocks, > >> rather than clock aliases > >> - reset handling will be implemented as part of the interconnect > >> driver somehow (no prototype / clear plans for that as of yet) > >> - all the hwmod stuff can be dropped > >> > >> The clock alias handling is still needed as a transition phase until > >> all the above is done, then we can start dropping them. Basically > >> anything that is using omap_hwmod depends on the clock aliases right > >> now. > > > > Ok, sounds good. Thanks. > > Stephen, any final comments on this series? I guess its too late to push > for 4.10, but I would like to get this merged early for 4.11 window. Hi Tero, No final comments from me. I needed to go back and forth with Tony about the clockdomain modeling, but it seems sensible to create clock providers from the clock domains if you want to pass those struct clk objects down to the drivers. One thing I wasn't able to follow exactly in the code is how the clockdomains are linking parent clocks from cm1, cm2, etc to the clock domains. Are the clockdomain providers calling clk_get() on the clocks that it *consumes*, or are the clockdomain providers never calling clk_get() on those clocks and just establishing the tree hierarchy at clk_register() time? Unless Stephen has any more review comments we can merge this into a clk-next based on v4.10-rc1 when that drops. Regards, Mike > > -Tero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
