Re: [PATCH] usb: dwc3: omap: Fix imprecise external abort and oops on boot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Tony Lindgren <tony@xxxxxxxxxxx> writes:
> * Felipe Balbi <balbi@xxxxxxxxxx> [161208 11:17]:
>> Tony Lindgren <tony@xxxxxxxxxxx> writes:
>> > The call to pm_runtime_get_sync() in dwc3_omap_probe() will use it.
>> 
>> right, but there's no runtime suspend until ->remove(). IOW, after
>> pm_runtime_get_sync(), all necessary clocks should already be
>> enabled. If they aren't, there's either an erratum or a bug in drivers/clk/ti/
>
> I think it's some dependency to the dwc3 core probe. That's because I'm
> able to read and print out the wrapper interrupt registers just fine
> before the imprecise external abort happens in probe. So that means it's
> something dwc3 specific after the TI wrapper module clckctl bit.
>
>> > Is there also some dwc3 internal clock? If we assume the usb_otg_ss
>> > module is properly enabled it could be some dwc3 internal clock not
>> > enabled?
>> 
>> no extra clocks.
>
> It seems that if we get an interrupt before dwc3 core has probed with
> of_platform_populate(), we get the imprecise external abort.

that's pretty odd. hwmod doesn't know about dwc3 core device, only
usb_otg_ss (dwc3-omap.c).

>> is IRQ status already 0x2121 from u-boot prompt?
>
> Yes md 0x4A020034 shows 0x2121.

okay, so maybe something left from even earlier? OMAP5 can boot off USB
peripheral.

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux