From: Alexandru Gagniuc <alex.g@xxxxxxxxxxxx> Date: Mon, 5 Dec 2016 17:33:53 -0800 > Support for setting the RGMII_IDMODE bit was added in commit: > "drivers: net: cpsw-phy-sel: add support to configure rgmii internal delay" > However, that commit did not add the symmetrical clearing of the bit > by way of setting it in "mask". Add it here. > > Note that the documentation marks clearing this bit as "reserved", > however, according to TI, support for delaying the clock does exist in > the MAC, although it is not officially supported. > We tested this on a board with an RGMII to RGMII link that will not > work unless this bit is cleared. > > Signed-off-by: Alexandru Gagniuc <alex.g@xxxxxxxxxxxx> Commits must be referenced by both short-form SHA1-ID as well as the commit header text. And since this change is fixing that commit, you should also provide a proper "Fixes: " tag on the line right before your signoff. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
