On 10/12/2016 08:33 AM, Bjorn Helgaas wrote:
> Do the basic pcie_port setup in the probe function for consistency with
> other drivers. No functional change intended.
Other drivers may do this, but it is really logical? All the pcie_port
work and variables are isolated to the add_pcie_port function, now it
they are mixed into probe as well, I don't see any benefit to this
style, perhaps the other drivers should become more like this.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> ---
> drivers/pci/host/pci-dra7xx.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> index efb24b8..bb77c35 100644
> --- a/drivers/pci/host/pci-dra7xx.c
> +++ b/drivers/pci/host/pci-dra7xx.c
> @@ -267,13 +267,9 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> struct platform_device *pdev)
> {
> int ret;
> - struct pcie_port *pp;
> + struct pcie_port *pp = &dra7xx->pp;
> + struct device *dev = pp->dev;
> struct resource *res;
> - struct device *dev = &pdev->dev;
> -
> - pp = &dra7xx->pp;
> - pp->dev = dev;
> - pp->ops = &dra7xx_pcie_host_ops;
>
> pp->irq = platform_get_irq(pdev, 1);
> if (pp->irq < 0) {
> @@ -320,6 +316,7 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
> void __iomem *base;
> struct resource *res;
> struct dra7xx_pcie *dra7xx;
> + struct pcie_port *pp;
> struct device *dev = &pdev->dev;
> struct device_node *np = dev->of_node;
> char name[10];
> @@ -331,6 +328,10 @@ static int __init dra7xx_pcie_probe(struct platform_device *pdev)
> if (!dra7xx)
> return -ENOMEM;
>
> + pp = &dra7xx->pp;
> + pp->dev = dev;
> + pp->ops = &dra7xx_pcie_host_ops;
> +
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> dev_err(dev, "missing IRQ resource\n");
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
