* aford173@xxxxxxxxx <aford173@xxxxxxxxx> [160902 12:25]:
> --- a/arch/arm/boot/dts/omap3.dtsi
> +++ b/arch/arm/boot/dts/omap3.dtsi
> @@ -564,6 +564,14 @@
> status = "disabled";
> };
>
> + sgx: sgx@5000000 {
> + compatible = "ti,sgx";
> + ti,hwmods = "gfx";
I think you may have a naming mismatch between "gfx" and
"sgx"?
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -3654,6 +3654,52 @@ static struct omap_hwmod_ocp_if omap34xx_l4_core__ssi = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +
> +/* gfx */
> +/* Pseudo hwmod for reset control purpose only */
> +
> +
> +static struct omap_hwmod_class omap3xxx_gfx_hwmod_class = {
> + .name = "sgx",
> +};
> +
> +static struct omap_hwmod_rst_info omap3xxx_gfx_resets[] = {
> + { .name = "sgx", .rst_shift = 0, .st_shift = 0},
> +};
> +
> +struct omap_hwmod omap3xx_gfx_hwmod = {
> + .name = "sgx",
> + .class = &omap3xxx_gfx_hwmod_class,
> + .clkdm_name = "sgx_clkdm",
> + .main_clk = "sgx_fck",
> + .prcm = {
> + .omap2 = {
> + .module_offs = OMAP3430ES2_SGX_MOD,
> + .prcm_reg_id = 1,
> + .module_bit = OMAP3430ES2_CM_FCLKEN_SGX_EN_SGX_SHIFT,
> + }
> + },
> + .rst_lines = omap3xxx_gfx_resets,
> + .rst_lines_cnt = ARRAY_SIZE(omap3xxx_gfx_resets),
> +};
You're missing the stuff hwmod is really needed for, the
OCP_SYSCONFIG and others for rev_offs, sysc_offs and
sysc_flags. See for example omap44xx_gpu_sysc. Note that
omap3 does not have clkctrl_offs.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
