Hi, On Fri, Jun 24, 2016 at 11:35:15AM +0530, Mugunthan V N wrote: > On Thursday 23 June 2016 06:26 PM, Ivan Khoronzhuk wrote: > >> + if (pool->cpumap) { > >> + dma_free_coherent(pool->dev, pool->mem_size, pool->cpumap, > >> + pool->phys); > >> + } else { > >> + iounmap(pool->iomap); > >> + } > > single if, brackets? > > if() has multiple line statement, so brackets are must. Another paint to the bikeshed, seems documented coding style mentions otherwise. Regards afzal -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html