On Mon, Jun 20, 2016 at 02:13:30PM +0530, Keerthy wrote: > +static struct tps65217_regulator_data regulator_data[TPS65217_NUM_REGULATOR]; Why is this a static global? > + /* Store default strobe info */ > + ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val); > + > + regulator_data[i].strobe = val & regulators[i].bypass_mask; > + Not sure what this is doing... I think this needs splitting up a bit, it looks like it's a bit more than just adding the ops (which should be generic things), that bit seems OK but there's these other bits in there as well.
Attachment:
signature.asc
Description: PGP signature
