Hello, On Tue, Mar 22, 2016 at 02:12:08PM +0100, yegorslists@xxxxxxxxxxxxxx wrote: > From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx> > > uart_handle_cts_change() should be called in IRQ locked state, hence > use port->lock to disable interrupts. I think the wording of the commit log is not exact. uart_handle_cts_change should be called with port->lock held. And for this to be save you must also disable irqs. The patch looks fine. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html