Hi,
Roger Quadros <rogerq@xxxxxx> writes:
>>> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
>>> index 22e9606..51ca098 100644
>>> --- a/drivers/usb/dwc3/dwc3-omap.c
>>> +++ b/drivers/usb/dwc3/dwc3-omap.c
>>> @@ -274,19 +274,25 @@ static irqreturn_t dwc3_omap_interrupt(int irq, void *_omap)
>>> {
>>> struct dwc3_omap *omap = _omap;
>>> u32 reg;
>>> + int ret = IRQ_NONE;
>>>
>>> reg = dwc3_omap_read_irqmisc_status(omap);
>>>
>>> + if (reg)
>>> + ret = IRQ_HANDLED;
>>
>> you can avoid the local variable by returning early here.
>
> How can we return early? we need to check irq0_status as well right?
Oh, that's true.
There's one thing that I noticed though. dma_status is only written to,
never read, so you should be able to remove it completely (a bit
off-topic, sorry).
--
balbi
Attachment:
signature.asc
Description: PGP signature
