Re: [PATCH 1/4] mailbox/omap: store mailbox interrupt type in omap_mbox_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/07/2016 02:37 AM, Suman Anna wrote:
The interrupt type used for identifying the layout of the interrupt
configuration registers between OMAP4+ SoCs and older SoCs is stored
only in the sub-mailbox structures for easier access. Store this type
in the the omap_mbox_device structure as well along with the other
global variables. This is being done to facilitate the context save
and restore of appropriate registers during system suspend/resume.

Signed-off-by: Suman Anna <s-anna@xxxxxx>
---
  drivers/mailbox/omap-mailbox.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/mailbox/omap-mailbox.c b/drivers/mailbox/omap-mailbox.c
index 84cafc02e761..adf37f494690 100644
--- a/drivers/mailbox/omap-mailbox.c
+++ b/drivers/mailbox/omap-mailbox.c
@@ -90,6 +90,7 @@ struct omap_mbox_device {
  	void __iomem *mbox_base;
  	u32 num_users;
  	u32 num_fifos;
+	u32 intr_type;
  	struct omap_mbox **mboxes;
  	struct mbox_controller controller;
  	struct list_head elem;
@@ -828,6 +829,7 @@ static int omap_mbox_probe(struct platform_device *pdev)
  	mdev->dev = &pdev->dev;
  	mdev->num_users = num_users;
  	mdev->num_fifos = num_fifos;
+	mdev->intr_type = intr_type;
  	mdev->mboxes = list;

  	/* OMAP does not have a Tx-Done IRQ, but rather a Tx-Ready IRQ */


This smth. which definitely has to be done using compatible props.
Why not to pass more info through of_device_id->data?



--
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux