On 04/01/2016 07:44 AM, Ben Hutchings wrote: > The I2C{1,2}, MCSPI{1,2}, UART{1,2}, QSPI1, USB{1,2}, RGMII > and ATL functions can each be wired in only one way. Reduce > duplication by defining that in dra74x.dtsi. > > Signed-off-by: Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx> > --- > arch/arm/boot/dts/am57xx-beagle-x15.dts | 50 +--------- > arch/arm/boot/dts/dra7-evm.dts | 142 +------------------------- > arch/arm/boot/dts/dra74x.dtsi | 171 ++++++++++++++++++++++++++++++++ > 3 files changed, 174 insertions(+), 189 deletions(-) NAK. Couple of reasons: A) Based on AM57xx/DRA7 SoC definitions these pin configuration should actually be deleted since the pinmuxing is only supposed to be done in u-boot (thanks to IODelay and other glitch constraints documented in TRM). B) newer packaging plans do take place that will make reuse of dra74x.dtsi harder by consolidating the pinmux in a central location. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html