On 03/31/2016 10:06 AM, Roger Quadros wrote: > Vagrant, > > On 30/03/16 23:08, Vagrant Cascadian wrote: >> On 2016-03-30, Roger Quadros wrote: >>> On 24/03/16 01:00, Nishanth Menon wrote: >>>> On 03/23/2016 03:16 PM, Vagrant Cascadian wrote: >>>>> ethernet. Unfortunately, eSATA doesn't seem to work when compiled as a >>>>> module, although I have it working as a built-in with linux 4.5-rc6. >>>> >>>> >>>> weird. I could swear that omap2plus_defconfig did work with eSATA last >>>> I tested... probably built in though.. >>>> >>>> Could you file a https://bugzilla.kernel.org/ bug with details and >>>> .config involved? >> >> Haven't created a bugzilla account yet... >> >> >>> I just tired with omap2plus_defconfig with CONFIG_ATA=m and CONFIG_SATA_AHCI_PLATFORM=m >>> on v4.5 + u-boot 2016.03 and eSATA worked fine. >>> >>> I need to know the exact .config that you used to debug the issue. Thanks. >> >> Thanks for following up. I recently tried with 4.6-rc1 and the attached >> config, which is based on Debian's multiplatform builds of the kernel. >> >> I'm also starting to suspect some of the patches applied to u-boot >> 2016.03 might be interfering, which were forward-ported from ti's >> u-boot; will try without those u-boot patches applied. > > At least with omap2plus_defconfig with CONFIG_TI_PIPE3=m, > CONFIG_ATA=m and CONFIG_SATA_AHCI_PLATFORM=m I can get SATA to break. > > Can you please try this patch to u-boot? It seemed to work for me. > > --- > From: Roger Quadros <rogerq@xxxxxx> > Date: Thu, 31 Mar 2016 17:46:55 +0300 > Subject: [PATCH] board: ti: am57xx: Prevent init_sata() from being called > twice > > init_sata() is done as part of scsi_init() in > arch/arm/cpu/armv7/omap-common/sata.c so no need to duplicate > it here. > > This seems to fix SATA problems in the kernel when CONFIG_TI_PIPE3 is > configured as loadable module. > > Reported-by: Vagrant Cascadian <vagrant@xxxxxxxxxx> > Cc: Cooper Jr., Franklin <fcooper@xxxxxx> > Cc: Nishanth Menon <nm@xxxxxx> > Signed-off-by: Roger Quadros <rogerq@xxxxxx> > --- > board/ti/am57xx/board.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c > index 042f9ab..34c5161 100644 > --- a/board/ti/am57xx/board.c > +++ b/board/ti/am57xx/board.c > @@ -264,7 +264,6 @@ int board_init(void) > > int board_late_init(void) > { > - init_sata(0); > /* > * DEV_CTRL.DEV_ON = 1 please - else palmas switches off in 8 seconds > * This is the POWERHOLD-in-Low behavior. > Hmm... would'nt this break sata u-boot support as a result? not to mention setup a dependency between bootloader and kernel (not that it is not already there..)... -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
