On 06/10/15 13:00, Tony Lindgren wrote: > * Roger Quadros <rogerq@xxxxxx> [151006 02:59]: >> On 06/10/15 11:33, Tony Lindgren wrote: >>> Does build and boot and use NAND work throughtout the series? >>> Otherwise we'll have hard time bisecting anything.. >> >> Yes it does with the following exceptions. >> >> - Patch 7 "memory: omap-gpmc: Remove NAND IRQ code" breaks prefetch-irq mode >> but none of the boards seem to be using it so it shouldn't break NAND on existing boards. >> At patch 9 "mtd: nand: omap2: manage NAND interrupts" prefetch-irq mode is working again. >> Do you want me to squash patches 7,8,9 so that pre-fetch irq is not broken at any point? > > OK, no that's fine, no need to squash them together then. > >> - Then at patch 11 "mtd: nand: omap: Clean up device tree support" we break NAND on all DT >> boards as we expect NAND to be a real child node with compatible id. Simply applying the >> DT patch at this point makes it work again. > > Hmm can we at least warn about incompatible DT entry when somebody boots > with an older dtb? Yes that could be done. It looks like we can use the missing compatible property to identify that it is and old DT entry. I'll send a v4 of patch 11. cheers, -roger > >>>> Test procedure was to read an existing ubifs partition, >>>> create a new one and read it back. >>>> >>>> Need you to Ack if it looks good. >>>> Do you mind taking it via omap-soc once MTD maintainers ack their relevant parts? >>> >>> Sure. I'll try to do some testing on the series first too. >>> >> Thanks. >> >>> Can the dts changes be merged separtely? Otherwise we'll have >>> a dependency between dts branch and the GPMC/NAND changes. >> >> I'm afraid no. Patch 11 makes us incompatible with the old DT. > > OK. If we can warn about that, then the out of tree users will > have easier time to update their dts file. > > Regards, > > Tony > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
