* Felipe Balbi <balbi@xxxxxx> [151005 09:13]: > On Mon, Oct 05, 2015 at 09:02:25AM -0700, Tony Lindgren wrote: > > * Felipe Balbi <balbi@xxxxxx> [151005 08:29]: > > > On Mon, Oct 05, 2015 at 04:01:45AM -0700, Tony Lindgren wrote: > > > > * Felipe Balbi <balbi@xxxxxx> [150929 13:48]: > > > > > since now we can reuse __omap_sync32k_timer_init() > > > > > for OMAP3-like devices, we can safely remove > > > > > __omap_gptimer_init(). > > > > > > > > There are tons of boards out there that need to use the > > > > high frequency ocillator source with gptimer because of the > > > > beagleboard B4 and earlier issue #7. So we need to provide > > > > both options for the boards. Using the high frequency > > > > oscillator source blocks deeper idle states in hardware > > > > so those devices are usable. > > > > > > have a closer look, that hasn't changed > > > > Oh right, you added the argument in the previous patch. > > Maybe update the description a bit to make that clear? > > I understood that we can only use the sync32k source now.. > > > > The __omap_sync32k_timer_init should not be called > > "sync32k" as that's TRM name for the always-on counter :) > > that's renamed on a follow-up patch, too ;-) OK so then I suggest updating the description with something like "With __omap_sync32k_timer_init() now taking the clock source as a parameter, we no longer need __omap_gptimer_init(). Note that __omap_sync32k_timer_init() gets renamed in the later patches as it's no longer 32k source specific". Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
