On Mon, Mar 16, 2009 at 12:04:39PM +0200, Adrian Hunter wrote: > Russell King - ARM Linux wrote: >> On Tue, Mar 10, 2009 at 02:06:08PM -0700, Tony Lindgren wrote: >>> From: Adrian Hunter <adrian.hunter@xxxxxxxxx> >>> >>> Add 1 to buffer length for null terminator. >> >> Yes, and: >> >> sprintf(twl->name, "mmc%islot%i", c->mmc, 1); >> >> should be snprintf to ensure that it can't overflow the buffer. >> > > There are only 3 controllers and everyone numbers them 1, 2 and 3. So? You've already had a buffer overflow, so it's clearly time that this code got fixed properly. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
