On Sun, Mar 15, 2009 at 07:27:32PM +0200, Grazvydas Ignotas wrote: > On Sun, Mar 15, 2009 at 6:04 PM, Russell King - ARM Linux > <linux@xxxxxxxxxxxxxxxx> wrote: > > On Tue, Mar 10, 2009 at 02:10:00PM -0700, Tony Lindgren wrote: > >> ... Array size for hsmmc[] is specified > >> because hsmmc[2].name is needed for MMC3 name. > > > > I see nothing in this patch which requires that. > > Right, but there is already some code in twl4030_mmc_init() of mmc-twl4030.c: > > struct twl_mmc_controller *twl = hsmmc + c->mmc - 1; > <snip> > sprintf(twl->name, "mmc%islot%i", c->mmc, 1); > > .. which basically writes to hsmmc[2].name for MMC3. So, it's nothing really to do with hsmmc[2].name being required, it's more a case of needing to have the 3rd MMC interface included. The comment in the commit is *really* misleading. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
