Re: [PATCH 12/12] ARM: OMAP3: MUSB initialization for omap hw

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 10, 2009 at 02:16:28PM -0700, Tony Lindgren wrote:
> Patch modified by Tony to build the module based on
> CONFIG_USB_MUSB_SOC.

I don't see this.

> +# Platform specific device init code
> +obj-$(CONFIG_USB_MUSB_SOC)		+= usb-musb.o

So, if this can be a module, the file itself doesn't export any symbols
and doesn't have any module_init or module_exit functions.  So, if this
gets built as a module, it isn't useful.

> +void __init usb_musb_init(void)
> +{
> +	if (cpu_is_omap243x()) {
> +		musb_resources[0].start = OMAP243X_HS_BASE;
> +		musb_plat.clock = "usbhs_ick";

kill kill kill.

> +	} else {
> +		musb_resources[0].start = OMAP34XX_HSUSB_OTG_BASE;
> +		musb_plat.clock = "hsotgusb_ick";

kill kill kill.

clkdev removes the need for this sort of crap.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux