On Thu, Aug 06, 2015 at 01:42:32PM +0200, Michal Suchanek wrote: > On 6 August 2015 at 13:23, Mark Brown <broonie@xxxxxxxxxx> wrote: > > Sure, but at the end of the day it's just emitting standard SPI messages > > which don't know anything about flash. If those messages are a sensible > > interface here then why bother with the flag, we can just pattern match > > on the format of the message. If that doesn't work then probably this > > isn't a great interface and a separate, application specific interface > > makes more sense. > The messages are sensible interface for communicating with a device > that interprets a particular part of the mesasge as address and > another particular part of the message as command and sends same > amount of junk before reply as the flash chip would. If your device That's just a statement that it's possible to do things this way, it's not clear to me that it's an explanation as to why it is sensible to do so - the obvious thing to do there would be to specify the flash operation as a flash operation rather than reverse engineer the flash operation from the wire format. > happens to send reply immediately part of it is trashed. If it happens > to interpret address differently the data ends up in random part of > your memory. So no, that is not something you can autodetect. If this stuff doesn't appear in the spi_message in some observable form then I'd expect that any existing flash support is broken since a SPI controller that doesn't have any acceleration is just going to do what the message says. > At the end of the day you have valid SPI messages but the m25p80 layer > adds interpretation to those messages which may not always give > correct result. Which comes back to the thing I keep saying about needing some sort of information about what the flag means and the questions about why this is a good interface... > On the other hand, if you ever get to m25p80 or spi-nor you can assume > any message you send goes to a flash chip and insist that the > controller uses the flash-specific interface. There's an awful lot of flashes out there connected to controllers that don't implement any sort of acceleration for flash, I'm not convinced that your assumption there is valid. > If there is possibility of connecting different kind of devices to > multiple chipselects on the same master then you probably want to > select this option per message or per slave. We definitely need to account for that.
Attachment:
signature.asc
Description: Digital signature
