Re: [PATCH] tty: serial: 8250: omap: fix kernel crash in suspend-to-ram

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On Friday 24 July 2015 03:55 AM, Greg Kroah-Hartman wrote:
> On Thu, Jun 25, 2015 at 03:45:04PM +0530, Sekhar Nori wrote:
>> omap_device infrastructure has a suspend_noirq hook which
>> runtime suspends all devices late in the suspend cycle (see
>> _od_suspend_noirq() in arch/arm/mach-omap2/omap_device.c)
>>
>> This leads to a NULL pointer exception in 8250_omap driver
>> since by the time omap8250_runtime_suspend() is called, 8250_dma
>> driver has already set rxchan to NULL via serial8250_release_dma().
>>
>> Make an explicit check to see if rxchan is NULL in
>> runtime_{suspend|resume} hooks to fix this.
>>
>> Signed-off-by: Sekhar Nori <nsekhar@xxxxxx>
>> ---
>> This applies to latest linus/master. I can rebase and
>> resend after -rc1 is tagged if needed.
> 
> Please rebase against 4.2-rc3 and resend, I can't apply this one now as
> it fails.

I had resent this patch as part of a 7 series "tty: 8250: omap:
workaround for IP errata and a bug fix", version 2 of which you have
already applied. I should have come back and noted here that this patch
can be dropped.

Apologies for the confusion caused.

Thanks,
Sekhar

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux