On Tue, Jul 14, 2015 at 03:45:51PM +0100, Nariman Poushin wrote:
Please submit patches in the format covered in SubmittingPatches,
version information goes inside the [].
> Add support for writing sequences of registers / patches with specified
> delays (in microseconds). Logically separates the functionality using
> sequences of register writes from the functions that take register
> defaults, as adding a delay field on the reg_defaults can increase
> memory usage substantially.
This change doesn't do what the above changelog says. It introduces a
new struct reg_sequence and updates the multi write and patch APIs to
use that but it doesn't implement any delay functionality. Please
resend with a clearer changelog that describes why the struct is being
split out from the reg_defaults struct and makes it clear that this is
just a rename. It's probably best to also defer the addition of the
delay field until the second patch where this function is actually
implemented.
> +/**
> + * Register / Value pairs for sequences of writes, incorporating an optional
Register/value.
> + * delay in microseconds.
> + *
> + * @reg: Register address.
> + * @def: Register default value.
> + * @delay_us: Delay in microseconds
> + */
> +
> +struct reg_sequence {
No blank line between the kerneldoc and the struct (as is the style for
other kernel code).
Attachment:
signature.asc
Description: Digital signature
