Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paul,

On 16/07/15 04:47, Paul Walmsley wrote:
> Hi Roger
> 
> On Mon, 13 Jul 2015, Roger Quadros wrote:
> 
>> There are quite a few hwmods that don't have sysconfig register and so
>> _find_mpu_rt_port(oh) will return NULL thus preventing ready state check
>> on those modules after the module is enabled.
>>
>> This can potentially cause a bus access error if the module is accessed
>> before the module is ready.
>>
>> Get rid of the redundant _find_mpu_rt_port() check from the _wait_target_ready()
>> funcion for all the SoCs. The following PRCM register access that checks the
>> module ready state has nothing to do with module's SYSCONFIG or mpu_rt_port.
>>
>> e.g. this fixes the below DCAN bus access error on AM437x-gp-evm.
> 
> Could you update this patch to align with the discussion we had the 
> last time this was posted in December?  e.g., 
> 
> http://www.spinics.net/lists/arm-kernel/msg388002.html
> 
> You can ignore the problems with the VAR-SOM-OM that were discussed; those 
> were indeed due to an old DT file in use, as Suman suspected.
> 
> Let me know if you have any questions about it -

My bad. I forgot that I had posted this earlier and totally missed that thread. :P

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux