On 06/24/2015 10:36 AM, Grygorii Strashko wrote:
> On 06/23/2015 07:15 PM, Nishanth Menon wrote:
[...]
>> + ds1307->wakeirq = of_irq_get(node, 1);
>> + if (ds1307->wakeirq <= 0) {
>> + if (ds1307->wakeirq == -EPROBE_DEFER) {
>> + err = ds1307->wakeirq;
>> + goto exit;
>> + }
>> + ds1307->wakeirq = 0;
>> + goto no_irq;
>> + }
>
> Might be above code could be done a little bit simpler?
>
> err = of_irq_get(node, 1);
> if (err <= 0) {
> if (err == -EPROBE_DEFER)
> goto exit;
> goto no_irq;
I had considered it, but problem with this approach is that is err
does not get reset back to 0 and probe will fail as it flows through
the rest of the code.. which is not our intent.
> }
> ds1307->wakeirq = err;
>
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
