Re: [PATCH 0/7] OMAPDSS: use components (fix probing problems)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tomi,

Thank for the patches.

On Tuesday 16 June 2015 13:16:22 Tomi Valkeinen wrote:
> Hi,
> 
> I noticed that on some platforms omapdss did not probe successfully. Some
> resource was not available yet, but omapdss did not manage to handle
> deferred probing. The reason was the use of platform_driver_probe() in
> combination with how the omapdss module handles the drivers.
> 
> To fix this properly, the component system felt fine for the job, and it
> seems to work nicely.
> 
>  Tomi
> 
> Tomi Valkeinen (7):
>   OMAPDSS: move 'dss_initialized' to dss driver
>   OMAPDSS: refactor dss probe function
>   OMAPDSS: fix dss_init_ports error handling
>   OMAPDSS: remove uses of __init/__exit
>   OMAPDSS: reorder uninit calls
>   OMAPDSS: componentize omapdss
>   OMAPDSS: simplify submodule reg/unreg code

I've quickly reviewed the whole series and it looks good to me.

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

>  drivers/video/fbdev/omap2/dss/core.c  |  80 ++++--------
>  drivers/video/fbdev/omap2/dss/dispc.c |  42 +++++--
>  drivers/video/fbdev/omap2/dss/dpi.c   |  36 ++++--
>  drivers/video/fbdev/omap2/dss/dsi.c   |  27 +++-
>  drivers/video/fbdev/omap2/dss/dss.c   | 223 ++++++++++++++++++++-----------
>  drivers/video/fbdev/omap2/dss/dss.h   |  32 ++---
>  drivers/video/fbdev/omap2/dss/hdmi4.c |  28 ++++-
>  drivers/video/fbdev/omap2/dss/hdmi5.c |  28 ++++-
>  drivers/video/fbdev/omap2/dss/rfbi.c  |  32 ++++-
>  drivers/video/fbdev/omap2/dss/sdi.c   |  35 ++++--
>  drivers/video/fbdev/omap2/dss/venc.c  |  31 +++--
>  11 files changed, 396 insertions(+), 198 deletions(-)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux