On 10.06.2015 03:26, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > Cc: Russell King <linux@xxxxxxxxxxxxxxxx> > Cc: Sekhar Nori <nsekhar@xxxxxx> > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > Cc: Jason Cooper <jason@xxxxxxxxxxxxxx> > Cc: Andrew Lunn <andrew@xxxxxxx> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> > Cc: Gregory Clement <gregory.clement@xxxxxxxxxxxxxxxxxx> > Cc: Hans Ulli Kroll <ulli.kroll@xxxxxxxxxxxxxx> > Cc: Shawn Guo <shawn.guo@xxxxxxxxxx> > Cc: Sascha Hauer <kernel@xxxxxxxxxxxxxx> > Cc: Imre Kaloz <kaloz@xxxxxxxxxxx> > Cc: Krzysztof Halasa <khalasa@xxxxxxx> > Cc: Greg Ungerer <gerg@xxxxxxxxxxx> > Cc: Roland Stigge <stigge@xxxxxxxxx> > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > Cc: Daniel Mack <daniel@xxxxxxxxxx> > Cc: Haojian Zhuang <haojian.zhuang@xxxxxxxxx> > Cc: Robert Jarzmik <robert.jarzmik@xxxxxxx> > Cc: Simtec Linux Team <linux@xxxxxxxxxxxx> > Cc: Kukjin Kim <kgene@xxxxxxxxxx> > Cc: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> > Cc: Wan ZongShun <mcuos.com@xxxxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: linux-omap@xxxxxxxxxxxxxxx > Cc: linux-samsung-soc@xxxxxxxxxxxxxxx > --- > arch/arm/common/it8152.c | 2 +- > arch/arm/common/locomo.c | 2 +- > arch/arm/common/sa1111.c | 4 ++-- > arch/arm/mach-davinci/cp_intc.c | 2 +- > arch/arm/mach-dove/irq.c | 2 +- > arch/arm/mach-ebsa110/core.c | 2 +- > arch/arm/mach-footbridge/common.c | 2 +- > arch/arm/mach-footbridge/isa-irq.c | 8 ++++---- > arch/arm/mach-gemini/gpio.c | 2 +- > arch/arm/mach-gemini/irq.c | 2 +- > arch/arm/mach-imx/3ds_debugboard.c | 2 +- > arch/arm/mach-imx/mach-mx31ads.c | 2 +- > arch/arm/mach-iop13xx/irq.c | 2 +- > arch/arm/mach-iop32x/irq.c | 2 +- > arch/arm/mach-iop33x/irq.c | 2 +- > arch/arm/mach-ixp4xx/common.c | 2 +- > arch/arm/mach-ks8695/irq.c | 2 +- > arch/arm/mach-lpc32xx/irq.c | 2 +- > arch/arm/mach-netx/generic.c | 2 +- > arch/arm/mach-omap1/fpga.c | 2 +- > arch/arm/mach-omap1/irq.c | 2 +- > arch/arm/mach-pxa/balloon3.c | 2 +- > arch/arm/mach-pxa/irq.c | 1 - > arch/arm/mach-pxa/lpd270.c | 2 +- > arch/arm/mach-pxa/pcm990-baseboard.c | 2 +- > arch/arm/mach-pxa/pxa3xx.c | 2 +- > arch/arm/mach-pxa/viper.c | 2 +- > arch/arm/mach-pxa/zeus.c | 2 +- > arch/arm/mach-rpc/ecard.c | 2 +- > arch/arm/mach-rpc/irq.c | 16 ++++++++-------- > arch/arm/mach-s3c24xx/bast-irq.c | 2 +- > arch/arm/mach-s3c64xx/common.c | 2 +- > arch/arm/mach-sa1100/irq.c | 1 - > arch/arm/mach-sa1100/neponset.c | 4 ++-- > arch/arm/mach-w90x900/irq.c | 2 +- > 35 files changed, 45 insertions(+), 47 deletions(-) For the s3c24xx and s3c64xx it looks fine: Acked-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html