Re: [PATCH] ARM: dts: AM35xx: fix system control module clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Paul,

On 07-06-15 21:56, Paul Walmsley wrote:
On Sun, 7 Jun 2015, Jeroen Hofstee wrote:


Turns out my suspicion was wrong. This is what I know at the moment,
depending on the bootpins, u-boot will trigger a bad access when loading
a file over ethernet, but only the first time. Clearing the pending interrupt
before booting linux make the "USB_OTG address hole seen" go away.
Oh, too bad.  I had been hoping that you were right and that I was wrong
;-)  I'll try this on the CM-T3517 here.

I'd like to solicit your opinion on what to do here.  I wonder if, in the
L3 bus drivers, we should simply report, in a line or two, if any bus
errors were logged before the kernel starts?  That would help discriminate
between problems that the kernel is responsible for, vs. problems that
occur earlier in the boot process.  Any thoughts?


I am not sure this can be easily done in a general manner.  Since in general
linux doesn't know the bootloader, it can't rely on what peripherals are setup, so I doubt it is in general possible to store a copy of the interrupt registers really early. Besides that, when not hacking around, I guess during the really early boot stage it is unknown what the interrupt registers are in the first place and which clocks are needed. And even if it could be done, if there is a bug in that code, it would lead to bigger problems than it is trying to solve (a bit weird
backlogs).

I guess it would be easier to check these flags in u-boot right before the jump to linux (there is a cleanup_before_linux() or something name like that). [ Or fake
the boot and run the check as a separate command]. Unfortunately u-boot does
not have a complete driver model, so a implementation of that in todays u-boot
will lead to a complete #ifdef CONFIG_foo mesh.

So, if you ask me, no don't add it to linux, but to u-boot instead. But likely as feature for a later release which can query all drivers. (and doubt this should be limited to interrupt flags, runtime_test() could be called on all of them e.g. when entering a
command like runtime_test).

Regards,
Jeroen

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux