On Thursday 12 March 2009, Adrian Hunter wrote:
> > + }
> > } else {
> > - ret = twl_mmc_set_voltage(c, 0);
> > + if (c->vcc_aux)
> > + ret = regulator_enable(c->vcc_aux);
>
> Sorry for slow reply. Shouldn't that be regulator_disable() ?
Indeed it should be. In fact I think this probably explains
the failure I saw the other day, trying to go from 3.3V on one
chip down to 1.8V, where it failed (reasons unknown so far)
but the cleanup left vcc_aux active. Got patch? :)
I meant this one to be a patch/RFC ... so you could see how I
thought those issues should be addressed, vs the less general
patches you sent the other day. Actually merging this one
runs into that annoying regulator framework isssue on most
systems.
- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
