Re: [PATCH] tty: serial: omap: use mctrl_gpio helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Nishanth Menon <nm@xxxxxx> [150522 08:36]:
> On 05/22/2015 07:16 AM, yegorslists@xxxxxxxxxxxxxx wrote:
> > From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> > 
> > This patch permits to use GPIOs to control the CTS/RTS/DTR/DSR/DCD/RI
> > signals.
> > 
> > Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
> > ---
> >  .../devicetree/bindings/serial/omap_serial.txt     |    9 +
> >  drivers/tty/serial/Kconfig                         |    1 +
> >  drivers/tty/serial/omap-serial.c                   |  168 +++++++++++++++++++-
> >  3 files changed, 171 insertions(+), 7 deletions(-)
> 
> Would we rather move introducing new features to 8250_omap.c rather
> than doing that to omap-serial and keep feature creeping it such that
> we wont ever be able to switch to 8250_omap ?

Yes please. Also, do we really want to allow mapping
random GPIO pins to the UART driver? I guess it would be
handy for powering UART connected devices like BT up
and down..

There's one fix pending to 8250_omap for mainline BTW:

[PATCH] serial: 8250_omap: provide complete custom startup & shutdown callbacks

But other than that it seems to behave at least for me.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux