Thanks, Vaibhav Hiremath > -----Original Message----- > From: Tomi Valkeinen [mailto:tomi.valkeinen@xxxxxxxxx] > Sent: Wednesday, March 11, 2009 6:20 PM > To: Hiremath, Vaibhav > Cc: linux-omap@xxxxxxxxxxxxxxx > Subject: RE: Suspend/Resume support with Omap2fb > > On Wed, 2009-03-11 at 11:47 +0100, ext Hiremath, Vaibhav wrote: > > > > > > > > > How have you tested this? > > > > Have you also tested with "echo mem > /sys/power/state"? > > > > Are you using Kevin's power management tree? What is default > > > configuration of your kernel during this test? > > > > > > It's been some time since I tested it, but it did work on OMAP3 > SDP > > > with > > > the pm-branch. Only changed needed were the > > > get_last_off_on_transaction_id and omapfb -> omapdss. I also > tested > > > echo > > > mem > .... > > > > > > I'll try to find time to test it again with latest trees. > > > > > [Hiremath, Vaibhav] That would be great, I am also trying few > things here at my end. Hopefully I will get something. > > Yeah, it works ok for me. I rebased my DSS2 tree to latest l-o, then > merged pm-branch, and made the changes mentioned above. I get some > warnings from getnstimeofday when resuming the kernel, but they seem > to > be unrelated to DSS, and the image is fine after resume. I used my > dss_omap_3430sdp_defconfig and made the following commands to enable > PM: > > echo 1 > /sys/power/clocks_off_while_idle > echo 1 > /sys/power/enable_off_mode > echo 1 > /sys/power/voltage_off_while_idle > echo 1 > /sys/power/sleep_while_idle > [Hiremath, Vaibhav] Tomi, I looked into your latest code base, and I can see that you have added suspend and resume functionality and as you mentioned it is working for you. The only difference I could point out here is, I am handling suspend at driver level (fb and v4l2) and you are handling it at DSS2 level. I can give try to your implementation; tomorrow morning after reaching to office first thing I will try this and let you know. Just to share with wider audience, I am seeing some abrupt behavior and I doubt some timing synchronization is causing problem. I could see suspend is working if I comment "ovl->enable" or if I call "echo "gfx e:0 > /sys/devices/platform/omapfb/overlays". Although I have same implementation in omapfb_suspend and it does disables clock and overlay, system doesn't go to off state. It always gives error for dss_prwm. Tomi, Can you try enabling CONFIG_CPU_IDLE flag and see whether it is going to state5 or not? And I think it won't go due to obvious reasons, framebuffer will hold the clocks. You have to have something in your framebuffer driver to trigger display disable. I have implemented timer here to do that. I will send you the patch once I get rid of this issue. > Tomi > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
