RE: DSPBRIDGE+BRIDGE_DVFS: Crashes on multiple reload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Richard,

> -----Original Message-----
> From: Woodruff, Richard
> Sent: Wednesday, March 11, 2009 5:28 PM
> To: Menon, Nishanth; linux-omap@xxxxxxxxxxxxxxx
> Cc: ext Paul Walmsley; Nayak, Rajendra; Gupta, Ramesh
> Subject: RE: DSPBRIDGE+BRIDGE_DVFS: Crashes on multiple reload
> 
> 
> > driver as explained below. Looking for any advice to fix this issue :(
> 
> Does it need DVFS enabled to fail? Is voltage high enough (to current DM)?
> There were some issues there.
Yes, Rajendra's VDD change is merged in [1] pm branch.
> 
> A side and possibly related note is the below 0x800 is way too high and
> will likely result in screen or other fifo related effects. The delay
> target should be around 5uS (for 26Mhz sysclk) and half of that for 13MHz
> sysclk.
> 
> Given a value of 0xC8 with ARM at 125MHz, a vdd2-opp2 -> vdd2-opp3 takes
> 105uS using current code.  This it self is too high for some display
> fifos.  0x800 is out of the park high.
> 
> End note is needs tuning for DVFS.
> 
> configure_core_dpll:
>         ldr     r4, omap3_cm_clksel1_pll
>         ldr     r5, [r4]
>         ldr     r6, core_m2_mask_val    @ modify m2 for core dpll
>         and     r5, r5, r6
>         orr     r5, r5, r3, lsl #0x1B   @ r3 contains the M2 val
>         str     r5, [r4]
>         mov     r5, #0x800              @ wait for the clock to stabilise
>         cmp     r3, #2
>         bne     wait_clk_stable
>         bx      lr
It does not make sense for clock notifier_registration to oops out.. it has'nt come out of init even..

This looks like list_del missing in clock_notifier unregistration function :(. I have a patch in place.. sending in a few mins
Regards,
Nishanth Menon
[1] http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=shortlog;h=pm
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux