Hi Tony, Linus, On 05/12/2015 05:13 PM, Tony Lindgren wrote: > * Linus Walleij <linus.walleij@xxxxxxxxxx> [150512 02:01]: >> On Tue, Apr 21, 2015 at 6:08 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: >> >>> Looks like omap_gpio_irq_type can return early at several places >>> leaving a GPIO bank enabled without doing pm_runtime_put if wrong >>> GPIO arguments are passed. >>> >>> Instead of adding more complicated BANK_USED macros, let's fix the >>> issue properly. We can pass is_irq flag to omap_enable_gpio_module >>> and omap_disble_gpio_module. And with that we can remove all the >>> similar code elsewhere to get rid of most BANK_USED macros. >>> >>> Note that the reason for the BANK_USED macro is that we need to manage >>> PM runtime on per GPIO bank basis. In the long run we want to move to >>> using PM runtime counts for each GPIO line to determine if a GPIO >>> bank is used. Once we have a solution for omap_enable_gpio_module >>> and omap_disable_gpio_module, we can remove the remaining BANK_USED >>> macros. >>> >>> Cc: Felipe Balbi <balbi@xxxxxx> >>> Cc: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx> >>> Cc: Javier Martinez Canillas <jmartinez@xxxxxxxxxxxxxx> >>> Cc: Nishanth Menon <nm@xxxxxx> >>> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> >> >> There is so much discussion around this patch that I can't make >> up my mind whether I should apply this or some subsequent inline >> version of it. >> >> Holding this off for now... > > Yeah let's see what Grygorii comes up, sounds like he may have > a minimal fix coming up. Then we can do the rest as clean-up > later on. Thanks for your patience and sorry for delay - was ooo last week. I'll try to come up with some patches as soon as possible, and, yes, In my personal opinion, it could be better if OMAP GPIO driver will be reworked/cleaned up/fixed in a different way. -- regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
