* Felipe Balbi <balbi@xxxxxx> [150424 09:14]: > On Thu, Apr 23, 2015 at 04:56:22PM -0700, Tony Lindgren wrote: > > We currently get all kinds of errors building the omap gpio driver > > as a module starting with: > > > > undefined reference to `omap2_gpio_resume_after_idle' > > undefined reference to `omap2_gpio_prepare_for_idle' > > ... > > > > Let's fix the issue by adding inline functions to the header. > > Note that we can now also remove the two unused functions for > > omap_set_gpio_debounce and omap_set_gpio_debounce_time. > > > > Then doing rmmod on the module produces further warnings > > because of missing exit related functions. Let's add those. > > > > And finally, we can make the Kconfig entry just a tristate > > option that's selected for omaps. > > > > Cc: Felipe Balbi <balbi@xxxxxx> > > Cc: Javier Martinez Canillas <javier@xxxxxxxxxxxx> > > Cc: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx> > > Cc: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> > > Cc: Nishanth Menon <nm@xxxxxx> > > Cc: Santosh Shilimkar <ssantosh@xxxxxxxxxx> > > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > > Just to be clear: when GPIO is a module, we can't really idle, can we ? Right we cannot do off idle because of the context loss until we have some way to register driver specific idle functions. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
