On Thu, Apr 16, 2015 at 09:08:58AM -0700, Tony Lindgren wrote:
> * Sebastian Reichel <sre@xxxxxxxxxx> [150415 09:32]:
> > Hi,
> >
> > On Thu, Apr 09, 2015 at 02:48:43PM +0100, Russell King - ARM Linux wrote:
> > > On Thu, Apr 09, 2015 at 12:06:58AM +0100, Russell King - ARM Linux wrote:
> > > > On Tue, Apr 07, 2015 at 08:22:08AM -0700, Tony Lindgren wrote:
> > > > > Works for me. The above needs the following fix folded in to build:
> > > > >
> > > > > --- a/arch/arm/mm/proc-v7.S
> > > > > +++ b/arch/arm/mm/proc-v7.S
> > > > > @@ -532,7 +532,7 @@ __v7_ca9mp_proc_info:
> > > > > __v7_ca8_proc_info:
> > > > > .long 0x410fc080
> > > > > .long 0xff0ffff0
> > > > > - __v7_proc __v7_ca8mp_proc_info, proc_fns = ca8_processor_functions
> > > > > + __v7_proc __v7_ca8_proc_info, __v7_setup, proc_fns = ca8_processor_functions
> > > > > .size __v7_ca8_proc_info, . - __v7_ca8_proc_info
> > > > >
> > > > > #endif /* CONFIG_ARM_LPAE */
> > > >
> > > > Thanks, merged into the original patch.
> > >
> > > Do you want to give me an ack for this, thanks?
> >
> > I tried to test this together with Tony's follow up patch, but I get
> > this after applying the patch to v4.0:
> >
> > sre@earth ~/src/linux [430973-fix] % make -j4
> > CHK include/config/kernel.release
> > CHK include/generated/uapi/linux/version.h
> > CHK include/generated/utsrelease.h
> > make[1]: 'include/generated/mach-types.h' is up to date.
> > CALL scripts/checksyscalls.sh
> > CHK include/generated/compile.h
> > AS arch/arm/mm/proc-v7.o
> > arch/arm/mm/proc-v7.S: Assembler messages:
> > arch/arm/mm/proc-v7.S:535: Error: invalid operands (*ABS* and .text sections) for `|'
> > arch/arm/mm/proc-v7.S:535: Error: invalid operands (*ABS* and .text sections) for `|'
> > scripts/Makefile.build:294: recipe for target 'arch/arm/mm/proc-v7.o' failed
> > make[1]: *** [arch/arm/mm/proc-v7.o] Error 1
> > Makefile:947: recipe for target 'arch/arm/mm' failed
> > make: *** [arch/arm/mm] Error 2
> > make: *** Waiting for unfinished jobs....
>
> Maybe test the version in Linux next:
>
> a6d746789825 ("ARM: proc-v7: avoid errata 430973 workaround for non-Cortex A8 CPUs")
DONE with your your patch added on top:
Tested-By: Sebastian Reichel <sre@xxxxxxxxxx>
(on N900)
I guess we should also drop the CONFIG_ARM_ERRATA_430973 check from
pdata-quirks' nokia_n900_legacy_init() and just enable it unconditionally.
-- Sebastian
Attachment:
signature.asc
Description: Digital signature
