Hi Sakari, Thank you for the review. On Sunday 12 April 2015 17:31:09 Sakari Ailus wrote: > On Sun, Apr 12, 2015 at 03:28:13PM +0300, Laurent Pinchart wrote: > > diff --git a/drivers/staging/media/omap4iss/iss_csiphy.c > > b/drivers/staging/media/omap4iss/iss_csiphy.c index 7c3d55d..748607f > > 100644 > > --- a/drivers/staging/media/omap4iss/iss_csiphy.c > > +++ b/drivers/staging/media/omap4iss/iss_csiphy.c > > @@ -13,6 +13,7 @@ > > > > #include <linux/delay.h> > > #include <linux/device.h> > > +#include <linux/regmap.h> > > > > #include "../../../../arch/arm/mach-omap2/control.h" > > > > @@ -140,9 +141,11 @@ int omap4iss_csiphy_config(struct iss_device *iss, > > * - bit [18] : CSIPHY1 CTRLCLK enable > > * - bit [17:16] : CSIPHY1 config: 00 d-phy, 01/10 ccp2 > > */ > > - cam_rx_ctrl = omap4_ctrl_pad_readl( > > - OMAP4_CTRL_MODULE_PAD_CORE_CONTROL_CAMERA_RX); > > - > > + /* > > + * TODO: When implementing DT support specify the CONTROL_CAMERA_RX > > + * register offset in the syscon property instead of hardcoding it. > > + */ > > + regmap_read(iss->syscon, 0x68, &cam_rx_ctrl); > > Do you use platform data now? I guess the address is the same on all SoCs > that use the OMAP 4 ISS? Yes I use platform data for now. The address is the same on all SoCs on which I've tested the driver, which is a single SoC :-) I'll research that when implementing DT bindings. > Acked-by: Sakari Alius <sakari.ailus@xxxxxx> Thank you. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
