> Race here? See, McBSP is marked free before disabling the clocks and > thus omap_mcbsp_request can start enabling them. So should you keep > clock disabling after test for mcbsp->free as here now but mark McBSP > free only after clocks are disabled? > > I think you should send this as an separate fix since this should go to > the upstream also. Good comment... why do I always do everything in such a hurry, without thinking any =) Either that or leave clock disabling within the spin_lock covered code? (probably risky business) - Eero -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html