On Tuesday 10 March 2009, Adrian Hunter wrote: > @@ -61,6 +65,7 @@ static struct twl_mmc_controller { > struct omap_mmc_platform_data *mmc; > u8 twl_vmmc_dev_grp; > u8 twl_mmc_dedicated; > + bool vsim_18v; > char name[HSMMC_NAME_LEN + 1]; > } hsmmc[OMAP34XX_NR_MMC] = { > { I have an alternate approach to your patches #2, and #6 ... basically, as part of switching the mmc-twl4030 glue over to the regulator framework, each MMC device can have two named supplies. (And the glue should work with PMICs other than just the twl4030 family chips.) So an eMMC chip with both power rails switchable would set up one for Vcc, and a second for VccQ ... which need not be VSIM, and need not even use a twl4030. MMC2 and MMC3 would be able to switch VccQ on after Vcc, for eMMC ... or similarly for an SDIO chip with a switchable regulator. So your #2 patch won't be needed, since the second supply would be handled in a more general way; ditto #6. Some of the other patches will also be affected. I'll send patches implementing this as soon as I get them working on one more board. - Dave -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html