Hi, On Fri, Mar 20, 2015 at 05:11:23PM +0200, Grygorii.Strashko@xxxxxxxxxx wrote: > On 03/20/2015 01:00 AM, Tony Lindgren wrote: > > * grygorii.strashko@xxxxxxxxxx <grygorii.strashko@xxxxxxxxxx> [150319 10:26]: > >> From: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx> > >> Now in TI OMAP GPIO driver there are a lot of places where > >> System GPIO number calculated and then converted to GPIO offset. > >> What is worse is that in many place such conversation performed twice > >> or even three times. But actually, we don't need to do that at all, because > >> - gpiolib always passes GPIO offset to GPIO controller > >> - OMAP GPIO driver converted to use IRQ domain, so > >> struct irq_data->hwirq contains GPIO offset > >> > >> Hence, it is safe to convert all GPIO OMAP functions to use GPIO > >> offset instead of system GPIO numbers. Also, this allows to remove > >> unneeded conversations routines > >> #define GPIO_INDEX(bank, gpio) > >> #define GPIO_BIT(bank, gpio) > >> int omap_irq_to_gpio() > > > > Right on! This is excellent news. I've tested this set on top of -rc4 > > plus the patch mentioned below, and I'm not seeing regressions on > > the platforms I tested with. Wake up to smsc911x ping with off-idle > > still works on omap3. > > > > I only briefly tested on omap1 (osk5912), so I'like to wait for > > Aaro's ack before this gets merged. > > > > I found one build error, other than that, for the whole series > > please feel free to add: > > > > Tested-by: Tony Lindgren <tony@xxxxxxxxxxx> > > Thanks Tony. > Yep. I'll wait for news from Aaro then will re-send if ok. Works fine on 770 and E3. Tested-by: Aaro Koskinen <aaro.koskinen@xxxxxx> A. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
