* grygorii.strashko@xxxxxxxxxx <grygorii.strashko@xxxxxxxxxx> [150319 10:26]:
> From: Grygorii Strashko <grygorii.strashko@xxxxxxxxxx>
>
> Convert GPIO IRQ functions to use GPIO offset instead of system
> GPIO numbers. This allows to drop unneeded conversations between
> system GPIO <-> GPIO offset which are done in many places and
> many times.
> It is safe to do now because:
> - gpiolib always passes GPIO offset to GPIO controller
> - OMAP GPIO driver converted to use IRQ domain, so
> struct irq_data->hwirq contains GPIO offset
>
> This is preparation step before removing:
> #define GPIO_INDEX(bank, gpio)
> #define GPIO_BIT(bank, gpio)
> int omap_irq_to_gpio()
...
> static void omap_gpio_unmask_irq(struct irq_data *d)
> {
> struct gpio_bank *bank = omap_irq_data_get_bank(d);
> - unsigned int gpio = omap_irq_to_gpio(bank, d->hwirq);
> + unsigned offset = d->hwirq;
> unsigned int irq_mask = GPIO_BIT(bank, gpio);
> u32 trigger = irqd_get_trigger_type(d);
> unsigned long flags;
This series up to this patch produces a build error that
would break git bisect:
drivers/gpio/gpio-omap.c: In function ‘omap_gpio_unmask_irq’:
drivers/gpio/gpio-omap.c:866:37: error: ‘gpio’ undeclared (first use in this function)
unsigned int irq_mask = GPIO_BIT(bank, gpio);
Applying the following patch makes things build again.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
