On 03/18/2015 08:24 PM, Sergei Shtylyov wrote:
Hello.
On 03/18/2015 05:44 PM, Tero Kristo wrote:
There is no need to read the register with every invocation of the
function,
as the value is constant. Thus, cache the value in a static variable.
Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
---
arch/arm/mach-omap2/id.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
index 2a2f4d5..1f5949f 100644
--- a/arch/arm/mach-omap2/id.c
+++ b/arch/arm/mach-omap2/id.c
@@ -52,7 +52,10 @@ EXPORT_SYMBOL(omap_rev);
int omap_type(void)
{
- u32 val = 0;
+ static u32 val = OMAP2_DEVICETYPE_MASK + 1;
+
+ if (val < OMAP2_DEVICETYPE_MASK)
<=, perhaps?
Hmm right, there is something fishy with this patch. Basically either
comparison works as the MASK is a shifted value which is always several
magnitudes larger than the resulting omap_type value itself. The +1 part
in the init value is completely unnecessary though.
-Tero
+ return val;
[...]
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
