* Mike Turquette <mturquette@xxxxxxxxxx> [150306 11:18]: > Quoting Tero Kristo (2015-02-25 11:04:18) > > There is a case where NULL can be a valid return value for > > ti_clk_get_reg_addr, specifically the case where both the provider index > > and register offsets are zero. In this case, the current error checking > > against a NULL pointer will fail. Thus, change the API to return a > > ERR_PTR value in an error case, and change all the users of this API to > > check against IS_ERR instead. > > > > Signed-off-by: Tero Kristo <t-kristo@xxxxxx> > > Cc: Michael Turquette <mturquette@xxxxxxxxxx> > > Looks good to me. ... > > --- > > drivers/clk/ti/apll.c | 5 +++-- > > drivers/clk/ti/autoidle.c | 2 +- > > drivers/clk/ti/clk.c | 7 ++++--- > > drivers/clk/ti/divider.c | 4 ++-- > > drivers/clk/ti/dpll.c | 6 +++--- > > drivers/clk/ti/gate.c | 4 ++-- > > drivers/clk/ti/interface.c | 2 +- > > drivers/clk/ti/mux.c | 4 ++-- > > 8 files changed, 18 insertions(+), 16 deletions(-) Can this patch be queued separately by Mike or is there some dependency to this series? Other than wondering about the above and the dts related comments, this series works for me with PM tests. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
