On Fri, Mar 13, 2015 at 5:13 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > * Eliad Peller <eliad@xxxxxxxxxx> [150312 05:10]: >> Now that we have wlcore device-tree bindings in place >> (for both wl12xx and wl18xx), remove the legacy >> wl12xx_platform_data struct, and move its members >> into the platform device data (that is passed to wlcore) >> >> Davinci 850 is the only platform that still set >> the platform data in the legacy way (and doesn't >> have DT bindings), so remove the relevant >> code/Kconfig option from the board file (as suggested >> by Sekhar Nori) >> >> Signed-off-by: Luciano Coelho <luca@xxxxxxxxx> >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> >> --- >> arch/arm/mach-davinci/Kconfig | 11 --- >> arch/arm/mach-davinci/board-da850-evm.c | 113 ------------------------- >> drivers/net/wireless/ti/wilink_platform_data.c | 25 ------ >> drivers/net/wireless/ti/wl12xx/main.c | 19 ++--- >> drivers/net/wireless/ti/wlcore/boot.c | 1 - >> drivers/net/wireless/ti/wlcore/main.c | 4 +- >> drivers/net/wireless/ti/wlcore/sdio.c | 75 +++++----------- >> drivers/net/wireless/ti/wlcore/wlcore_i.h | 8 +- >> include/linux/wl12xx.h | 25 ------ >> 9 files changed, 36 insertions(+), 245 deletions(-) > > I got a build error related to the SPI driver with this series, probably > need to update this patch: > > drivers/net/wireless/ti/wlcore/spi.c: In function ‘wl1271_probe’: > drivers/net/wireless/ti/wlcore/spi.c:334:11: error: ‘struct wlcore_platdev_data’ has no member named ‘pdata’ > pdev_data.pdata = dev_get_platdata(&spi->dev); > ^ > drivers/net/wireless/ti/wlcore/spi.c:335:16: error: ‘struct wlcore_platdev_data’ has no member named ‘pdata’ > if (!pdev_data.pdata) { > yeah, i missed it :/ looks like there's no platform that defines platform data for it. i'll replace the dev_get_platdata() with a function that only parses the clock-frequency properties (the irq is taken in this case from the spi_device). (or maybe i should just drop it, as no one actually uses it?) thanks, Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html