Hi, * George G. Davis <gdavis@xxxxxxxxxx> [090302 08:19]: > When building ASoC drivers as modules for SND_OMAP_SOC_MCBSP based > targets, the build fails because omap_ctrl_{read,write}l lack exports. > So add the missing exports for omap_ctrl_{read,write}[bwl] to allow > building these ASoC (and other) drivers as modules. I think Paul has some comments on how the clock framework should handle this case without needing to export the omap_ctrl_read/write. Regards, Tony > Signed-off-by: George G. Davis <gdavis@xxxxxxxxxx> > Acked-by: Jarkko Nikula <jarkko.nikula@xxxxxxxxx> > --- > arch/arm/mach-omap2/control.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-omap2/control.c b/arch/arm/mach-omap2/control.c > index 5f3aad9..6b14639 100644 > --- a/arch/arm/mach-omap2/control.c > +++ b/arch/arm/mach-omap2/control.c > @@ -36,29 +36,35 @@ u8 omap_ctrl_readb(u16 offset) > { > return __raw_readb(OMAP_CTRL_REGADDR(offset)); > } > +EXPORT_SYMBOL(omap_ctrl_readb); > > u16 omap_ctrl_readw(u16 offset) > { > return __raw_readw(OMAP_CTRL_REGADDR(offset)); > } > +EXPORT_SYMBOL(omap_ctrl_readw); > > u32 omap_ctrl_readl(u16 offset) > { > return __raw_readl(OMAP_CTRL_REGADDR(offset)); > } > +EXPORT_SYMBOL(omap_ctrl_readl); > > void omap_ctrl_writeb(u8 val, u16 offset) > { > __raw_writeb(val, OMAP_CTRL_REGADDR(offset)); > } > +EXPORT_SYMBOL(omap_ctrl_writeb); > > void omap_ctrl_writew(u16 val, u16 offset) > { > __raw_writew(val, OMAP_CTRL_REGADDR(offset)); > } > +EXPORT_SYMBOL(omap_ctrl_writew); > > void omap_ctrl_writel(u32 val, u16 offset) > { > __raw_writel(val, OMAP_CTRL_REGADDR(offset)); > } > +EXPORT_SYMBOL(omap_ctrl_writel); > > -- > 1.6.1.2.MVISTA > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html