2015-03-04 6:31 GMT+01:00 NeilBrown <neilb@xxxxxxx>: > On Tue, 3 Mar 2015 13:28:12 +0100 Andreas Fenkart <afenkart@xxxxxxxxx> wrote: >> While cover detect is only used by one platform (rx51), it >> complicates the card detect logic. By separating the code >> paths they both become easier to understand and maintain >> >> Patches have been tested by reverting: 95bebb5696ab >> 'mmc: omap_hsmmc: use mmc_of_parse to parse common mmc configuration' >> otherwise gpio detection is handled by mmc_of_parse > > Wouldn't it make more sense to put this core in mmc/core rather than in just > one host controller? Yes, I would very welcome that, since it would free the omap_hsmmc of the 'protection' mechanism that makes the driver clumsy. But as an initial step separating cover from card detect already seems enough for this series. Another thought was, that since only one platform is using it, the prospect of getting it merged into the core was minimal. > That way it would be available to all hosts, and you > wouldn't need to revert that patch. Oh sorry, seems I was unclear. I definitely do not want to revert that patch permanently, the opposite is true, I very much welcome it. Thanks for your work by the way. I only reverted it temporarily so I could test that the card detect logic still works with legacy board files, non-device-tree platforms. But since mmc_of_parse is setting the card detect pin, my changes could not be tested with my device-tree platform (bbone). So I reverted the above patch only for testing, afterwards I rebased the patches on top of it, before submitting Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
