On Mon, 2 Mar 2015 22:05:10 +0100 Pavel Machek <pavel@xxxxxx> wrote: > Hi! > > > The twl4030 charger has two current sources, 'USB' and 'AC' (which is > > really DC of course...). > > > > If 'AC' is providing current, we should set the current limit > > differently to when it isn't (and so USB is used). > > So split 'cur' into 'usb_cur' and 'ac_cur' and use accordingly. > > > > Now we must review the current setting on any interrupt or USB > > event which might indicate that the charger-source has changed. > > > > Signed-off-by: NeilBrown <neilb@xxxxxxx> > > > @@ -103,7 +104,9 @@ struct twl4030_bci { > > /* ichg values in uA. If any are 'large', we set CGAIN to > > ichg/_cur values > > > * '1' which doubles the range for half the precision. > > */ > > - int ichg_eoc, ichg_lo, ichg_hi, cur; > > + int ichg_eoc, ichg_lo, ichg_hi; > > + int usb_cur, ac_cur; > > > + /* If VAC exceeds 4.5V (MADC 11) and ac is enabled, set current > > + * for 'ac' > > /* > * If AC voltage exceeds 4.5V (MADC 11) and AC is enabled, set current > * for 'ac'. > > > Acked-by: Pavel Machek <pavel@xxxxxx> > Thanks - I made those changes, or something much like them. NeilBrown
Attachment:
pgpwRFxY5Vi1a.pgp
Description: OpenPGP digital signature