On 01/27/2015 06:50 PM, Tony Lindgren wrote:
* Tomi Valkeinen <tomi.valkeinen@xxxxxx> [150127 03:37]:
On 26/01/15 17:49, Tony Lindgren wrote:
I'm not sure if I miss something, but regmap_write does not protect from
problems if there are multiple users for the same registers. You need to
use regmap_update_bits() to get a protected read/write sequence, in
which you can change only the bits that you want to change.
To me it seems that issue can be fixed by making all the code use regmap.
AFAIK that should work for the legacy code too.
Even if everybody uses regmap, doing
v = regmap_read()
modify v
regmap_write(v)
is racy. regmap_update_bits() has to be used to protect the read/write
sequence. Which may be somewhat challenging at times with some strange
registers, the like Roger Q encountered recently related to CAN.
Yeah that's a good point.
Regards,
Tony
I have a v2 of this series ready now, which also moves control module
completely to use syscon for register accesses. The move to regmap is
done at later point though, not in this patch as Paul proposed, as the
changes to the rest of the series were not posted.
The race handling needs to be done on driver level to use
regmap_update_bits, my take on this is that we can post separate patches
against the individual drivers, once the regmap/syscon conversion has
been done. Mostly, the drivers do not touch same register anyway, so
getting any conflicts should be pretty rare. Moreover, this set does not
do anything for this anyway, if there are currently races with some
users of control module, these will be there still.
-Tero
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
